fix: Zig 0.16 compile and f32-exact museum tests - #8
Merged
Conversation
@Log1P is gone; pointless discard-then-use is an error; temporary struct literals are not lvalues for method calls; ProofNode premise slices cannot be *const. Lukasiewicz/Fréchet tests used == on 0.7+0.6-1 which is not exact in f32/f64. zig build test --summary all: 388/388 (Zig 0.16.0).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zig build testdid not compile on Zig 0.16.0 (@log1premoved, discard-then-use, temporary struct method call,*const ProofNodevs*ProofNode). Two tests used exact==on0.7+0.6-1(f32/f64).Local gate:
zig build test --summary all→ 388/388 (Zig 0.16.0).Does not un-draft #2. Does not restore marketing.