impl Zeroize for BoxedMontyParams - #1338
Draft
baloo wants to merge 1 commit into
Draft
Conversation
The intent is to add support for zeroize on RSA's qinv. BoxedMontyParams got placed in an Arc in RustCrypto#1143 but I'm not sure I follow the reason why. To implement Zeroize, this changes remove the Arc. The content is still placed on the heap (There is an underlying BoxedUint).
baloo
marked this pull request as draft
September 1, 2026 19:27
Member
Author
|
Let's make that a draft until we can figure out the reasoning behind Arc. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1338 +/- ##
==========================================
- Coverage 91.06% 91.05% -0.02%
==========================================
Files 189 189
Lines 22654 22651 -3
==========================================
- Hits 20630 20624 -6
- Misses 2024 2027 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The intent is to add support for zeroize on RSA's precomputed p_params and q_params.
BoxedMontyParams got placed in an Arc in #1143 but I'm not sure I follow the reason why.
To implement Zeroize, this changes remove the Arc. The content is still placed on the heap (There is an underlying BoxedUint).