Resolve docker executable to an absolute path - #7
Merged
Conversation
Every ProcessBuilder call invoked docker via a bare command name, relying on the process's PATH to resolve it (Sonar java:S4036). Add DockerExecutable, which scans PATH once at class-load time and caches the resolved absolute path, so later invocations use a fixed path instead of re-resolving through PATH each time. Portable across the Windows dev machine and the Linux Pi since it resolves at runtime rather than hardcoding an OS-specific path. Verified compile/checkstyle/full build pass, and confirmed the resolved absolute path runs identically to the bare command on the production Pi.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every ProcessBuilder call invoked docker via a bare command name, relying on the process's PATH to resolve it (Sonar java:S4036). Add DockerExecutable, which scans PATH once at class-load time and caches the resolved absolute path, so later invocations use a fixed path instead of re-resolving through PATH each time. Portable across the Windows dev machine and the Linux Pi since it resolves at runtime rather than hardcoding an OS-specific path.
Verified compile/checkstyle/full build pass, and confirmed the resolved absolute path runs identically to the bare command on the production Pi.