Fix/sandbox hardening followups - #6
Merged
Merged
Conversation
If the JVM dies mid-execution, the finally block in JavaRunnerService.run() never fires, leaking java-sandbox-* Docker containers and temp directories. This adds a periodic sweep that force-removes anything older than a safety margin past the execution timeout.
- Add --ulimit nofile/fsize to bound open file descriptors and per-file size inside the sandbox container, on top of the existing cap-drop/pids-limit/memory controls. Verified javac/java still run fine under these limits on the production Pi. - Pin the sandbox Docker image by digest instead of the 21-jdk tag, so an upstream tag update can't silently change what runs in production.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.