Fix/sandbox output concurrency limits - #5
Merged
Conversation
Adds a 1MB cap on captured container output (killed early if exceeded), bounds concurrent Docker executions to 2 via a blocking semaphore to match the host's real CPU capacity, and lowers the per-container memory limit from 512m to 256m based on empirical OOM testing.
If the concurrency limit is hit, requests now wait in a queue instead of failing, so the console message clarifies that a longer wait may just mean the sandbox is busy with other submissions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I created the limitation for memory on my Raspberry Pi 4, which is the host for this project. I added 256 MB of RAM per Docker container for running Sandbox Java code. I also added concurrency, so no more than two processors at the same time can run simultaneously, and if there are some extra, they just will wait by the semaphore principle.