Skip to content

fix: appSource conflict issue #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
D1-3105 merged 2 commits into from
Sep 4, 2026
Merged

fix: appSource conflict issue #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d5e795
Fix appSource conflict issue
D1-3105 Sep 2, 2026
9bcda75
fix: upload id issue
D1-3105 Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2,118 changes: 1,835 additions & 283 deletions api/serverless/openapi.yaml
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions internal/api/serverless/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,7 +499,7 @@ func (c *Client) ListVersions(ctx context.Context, appID string, params *ListVer
if resp.JSON200 == nil {
return pageOf[Version](nil, nil), nil
}
return pageOf(resp.JSON200.Data, resp.JSON200.NextCursor), nil
return pageOf(&resp.JSON200.Data, resp.JSON200.NextCursor), nil
case http.StatusUnauthorized:
return Page[Version]{}, problemToError(resp.ApplicationproblemJSON401, http.StatusUnauthorized)
case http.StatusForbidden:
Expand Down Expand Up @@ -559,7 +559,7 @@ func (c *Client) ListBuilds(ctx context.Context, appID string, params *ListBuild
if resp.JSON200 == nil {
return pageOf[Build](nil, nil), nil
}
return pageOf(resp.JSON200.Data, resp.JSON200.NextCursor), nil
return pageOf(&resp.JSON200.Data, resp.JSON200.NextCursor), nil
case http.StatusUnauthorized:
return Page[Build]{}, problemToError(resp.ApplicationproblemJSON401, http.StatusUnauthorized)
case http.StatusForbidden:
Expand Down
5 changes: 2 additions & 3 deletions internal/api/serverless/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,7 @@ func TestCreateApp(t *testing.T) {
source, err := NewCodeAppSource(CodeSourceUpsert{
BaseImage: "python:3.11-slim",
Codebase: CodebaseSource{
ModelFile: "app.py",
ZipBase64: "Zm9v",
UploadId: uuid.MustParse("019c7654-8b21-7abc-9123-abcdef123456"),
},
})
if err != nil {
Expand Down Expand Up @@ -452,7 +451,7 @@ func TestUpdateApp(t *testing.T) {
if body.Configuration == nil || body.Configuration.MaxWorkers == nil || *body.Configuration.MaxWorkers != maxWorkers {
t.Errorf("unexpected body: %s", raw)
}
if body.AppName != nil || body.AppSource != nil || body.Secrets != nil || body.EnvironmentVariables != nil || body.Endpoints != nil {
if body.AppName != nil || body.AppSource != nil || body.Secrets != nil || body.EnvironmentVariables != nil {
t.Errorf("patch included out-of-scope fields: %s", raw)
}
var rawMap map[string]json.RawMessage
Expand Down
Loading