3.0 - #474
Open
andrewdalpino wants to merge 598 commits into
Open
Conversation
408 fix issues in tests
* Intial commit * More progress * Fix namespacing * Fix coding style
apphp
self-requested a review
September 6, 2026 18:46
apphp
approved these changes
Sep 6, 2026
|
Another found with LLM. WDYT about this? Does it make sense or relevant at all? Fix: do the same as AdaBoost — score the model after the new tree is in the ensemble, remember tree count, and roll back only if quality got worse. Three changes in train():
Use <, not <=. Use $bestEnsembleSize, not $bestEpoch. |
Member
Author
|
Which algo are you talking about @apphp? |
apphp
approved these changes
Sep 7, 2026
src/Regressors/GradientBoost.php |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update:
HeandXavier 2initializersXavier 2now extendsHeas a deprecated alias