ENH: cache downloaded atmosphere netCDF datasets (#654) - #1137
Open
thatrandomasiandev wants to merge 1 commit into
Open
ENH: cache downloaded atmosphere netCDF datasets (#654)#1137thatrandomasiandev wants to merge 1 commit into
thatrandomasiandev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.ncfiles under~/.rocketpy_cache/atmosphere(override withROCKETPY_CACHE).set_atmospheric_modelcalls reuse disk.no_cache=FalsetoEnvironment.set_atmospheric_model(and Windy processing) so callers can force a fresh download without breaking existing callers.Notes / TODOs
OPeNDAP "Best" aggregations are virtual catalogs, not downloadable files, so this PR caches the extracted profiles RocketPy already materializes after the first fetch (same end-user outcome: reruns skip the network). Remaining follow-ups:
.nc(non-OPeNDAP)Fixes #654
Test plan
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 pytest tests/unit/environment/test_atmosphere_cache.pyno_cache=Trueforces re-download