ENH: plot flight center-of-pressure evolution (#954) - #1130
Open
thatrandomasiandev wants to merge 3 commits into
Open
ENH: plot flight center-of-pressure evolution (#954)#1130thatrandomasiandev wants to merge 3 commits into
thatrandomasiandev wants to merge 3 commits into
Conversation
Member
|
we need to see one or two examples of the new plot before merging it please |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1130 +/- ##
===========================================
+ Coverage 82.18% 82.54% +0.36%
===========================================
Files 122 128 +6
Lines 16355 16644 +289
===========================================
+ Hits 13441 13739 +298
+ Misses 2914 2905 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Author
|
@Gui-FernandesBR here are two examples from this branch:
Both generated with |
Member
|
the example plots don't really make sense |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Flight.plots.center_of_pressure()to plot CP position vs time, evaluated at the flight Mach number at each stepFlight.plots.all()and cover show/save paths in unit testsFixes #954
Test plan
PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 MPLBACKEND=Agg python -m pytest tests/unit/test_plots.py::test_flight_center_of_pressure_plot -qflight.plots.center_of_pressure()on a Calisto flight shows CP/CM/static-margin curves through first event time