ENH: add Flight post-step callback across all phases (#758) - #1128
Open
thatrandomasiandev wants to merge 1 commit into
Open
ENH: add Flight post-step callback across all phases (#758)#1128thatrandomasiandev wants to merge 1 commit into
thatrandomasiandev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
ruff/make lintfocused files) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.md— no action needed; an LLM workflow auto-updates it after mergeCurrent behavior
Discrete/continuous controllers are not a full-lifecycle observer: air-brake examples often terminate at apogee, and parachute phases are not meant to keep feeding actuator controllers. Users simulating ground-station / radio update code had no first-class hook that keeps running through descent.
Fixes #758
New behavior
Flight(..., post_step_callback=None)accepts an optional callable invoked once after every successful ODE solver step for the entire simulation, including parachute phases. Signature matches phase/node callbacks:callback(flight). Useflight.tandflight.y_solfor the current time and state.Breaking change
Additional information
calisto_robust, and that non-callables raiseTypeError.