BUG: sample StochasticFlight inputs once per simulation (#1090) - #1126
Open
thatrandomasiandev wants to merge 2 commits into
Open
BUG: sample StochasticFlight inputs once per simulation (#1090)#1126thatrandomasiandev wants to merge 2 commits into
thatrandomasiandev wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1126 +/- ##
===========================================
+ Coverage 82.18% 82.53% +0.34%
===========================================
Files 122 128 +6
Lines 16355 16619 +264
===========================================
+ Hits 13441 13716 +275
+ Misses 2914 2903 -11 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests//make lint) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.md— no action needed; an LLM workflow auto-updates it after mergeCurrent behavior
MonteCarlo.__run_single_simulationcalled_randomize_rail_length,_randomize_inclination, and_randomize_heading, each of which invokednext(self.dict_generator()). One simulation therefore drew three times; the Flight mixed values across draws whilelast_rnd_dict(and.inputs.txt) kept only the last draw.StochasticFlight.create_objecthad the same pattern forrail_length.Fixes #1090
New behavior
StochasticFlight._sample_flight_inputs()performs a single draw.create_objectandMonteCarlo.__run_single_simulationboth use that helper so flown rail/inclination/heading matchlast_rnd_dict. The_randomize_*helpers remain for single-field callers and still each draw once.Breaking change
Additional information
Focused unit tests assert create_object and
__run_single_simulationFlight inputs equallast_rnd_dict. Full slow suite not run in this contribution pass.