CI: keep per-matrix coverage artifacts and fail Codecov errors (#1088) - #1123
Open
thatrandomasiandev wants to merge 2 commits into
Open
Conversation
Gui-FernandesBR
force-pushed
the
ci/1088-coverage-matrix-artifacts
branch
from
August 11, 2026 01:56
8c9d125 to
146679f
Compare
Gui-FernandesBR
approved these changes
Aug 11, 2026
Gui-FernandesBR
force-pushed
the
ci/1088-coverage-matrix-artifacts
branch
from
August 12, 2026 02:42
146679f to
0e6eb73
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1123 +/- ##
===========================================
+ Coverage 82.18% 82.94% +0.76%
===========================================
Files 122 129 +7
Lines 16355 16901 +546
===========================================
+ Hits 13441 14019 +578
+ Misses 2914 2882 -32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
) The artifact renaming was the right diagnosis, but review turned up eight follow-ups: - fail_ci_if_error was unconditional, and forks get no secrets, so an external contributor would see red whenever the tokenless upload got rate limited. Tie it to the token, as RocketPy-Team#1088 prescribed. - overwrite: true was dropped. Artifacts are keyed by (run, name) and survive across attempts, so every leg of a re-run failed with 409 Conflict. The flaky VTK tests make re-runs routine. - needs: Pytest with no if: guard skipped CodecovUpload entirely when a single leg failed, sending Codecov nothing at all for the commit while .codecov.yml resolves that as an error. Run on !cancelled() and upload whatever legs did finish. - download-artifact exits 0 when pattern matches fewer artifacts than expected, so five of six reports looked like a clean run. Verify the count against the matrix size and refuse the silently-partial case. - Both .codecov.yml statuses were scoped to a `unit` flag that no upload has ever tagged, so the gate resolved over an empty flag set and measured nothing. The reports are unit + doctest + integration + acceptance combined, so drop the flag rather than mislabel them. - --cov-report=xml:<name> writes the per-leg filename directly, so the extra mv step goes away and if-no-files-found: error is reachable again instead of being masked by the mv failing first. - retention-days: 1, since artifacts per run went from 1 to 6 and CodecovUpload consumes them minutes later. - env: OS/PYTHON and .github/workflows/upload-to-codecov.yml were dead. The reusable workflow was called by nothing and was the only consumer of those two variables, while holding a second, diverging copy of the Codecov settings. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Gui-FernandesBR
force-pushed
the
ci/1088-coverage-matrix-artifacts
branch
from
August 12, 2026 22:30
2132b68 to
59851ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
coverage-${{ matrix.os }}-py${{ matrix.python-version }}) instead of overwriting a sharedcoveragename.coverage.xmlbefore upload sodownload-artifactmerge-multiple: truecan flatten all reports without clobbering identical basenames.coverage-*artifacts inCodecovUploadand upload the full set via Codecov'sdirectoryinput.fail_ci_if_error: trueso Codecov upload failures fail CI.Fixes #1088
Test plan
.github/**)coverage-*-py*artifactCodecovUploaddownloads all six and uploads without silent overwritefail_ci_if_error: true)