Fix operating_temperature default init values across sensor classes - #1118
Merged
Conversation
Member
|
we never merge against master, the heading branch should be the develop branch |
Gui-FernandesBR
force-pushed
the
master
branch
from
August 10, 2026 12:21
93ca2df to
1b49515
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1118 +/- ##
===========================================
+ Coverage 82.18% 82.51% +0.33%
===========================================
Files 122 128 +6
Lines 16355 16617 +262
===========================================
+ Hits 13441 13712 +271
+ Misses 2914 2905 -9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Docstring states that the sensor default operating_temperature in K is assumed to be 25 C = 25+273.15 = 298.15 K. The initialization value, however, was set to "25" and never converted from C to K creating a contradiction. Set new operating_temperature init values to 298.15 across Sensor classes.
Gui-FernandesBR
force-pushed
the
master
branch
from
August 12, 2026 02:46
ca18e54 to
cd5a156
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Docstring states that the sensor default
operating_temperaturewhich is in unit K is assumed to be 25 C = 25+273.15 = 298.15 K. The initialization value, however, was set to 25 across sensor classes and never converted from C to K creating a contradiction.Summary
Set operating_temperature default init values from
operating_temperature=25tooperating_temperature=298.15across Sensor classessensor.py,gyroscope.py,barometer.py, andaccelerometer.py.