Skip to content

Fix operating_temperature default init values across sensor classes - #1118

Merged
Gui-FernandesBR merged 1 commit into
RocketPy-Team:developfrom
vapsik:master
Aug 12, 2026
Merged

Fix operating_temperature default init values across sensor classes#1118
Gui-FernandesBR merged 1 commit into
RocketPy-Team:developfrom
vapsik:master

Conversation

@vapsik

@vapsik vapsik commented Aug 10, 2026

Copy link
Copy Markdown

Issue

Docstring states that the sensor default operating_temperature which is in unit K is assumed to be 25 C = 25+273.15 = 298.15 K. The initialization value, however, was set to 25 across sensor classes and never converted from C to K creating a contradiction.

Summary

Set operating_temperature default init values from operating_temperature=25 to operating_temperature=298.15 across Sensor classes sensor.py, gyroscope.py, barometer.py, and accelerometer.py.

@vapsik
vapsik requested a review from a team as a code owner August 10, 2026 10:31
@Gui-FernandesBR

Copy link
Copy Markdown
Member

we never merge against master, the heading branch should be the develop branch

@Gui-FernandesBR
Gui-FernandesBR changed the base branch from master to develop August 10, 2026 12:21

@Gui-FernandesBR Gui-FernandesBR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.51%. Comparing base (e0ff281) to head (1b49515).
⚠️ Report is 41 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1118      +/-   ##
===========================================
+ Coverage    82.18%   82.51%   +0.33%     
===========================================
  Files          122      128       +6     
  Lines        16355    16617     +262     
===========================================
+ Hits         13441    13712     +271     
+ Misses        2914     2905       -9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Docstring states that the sensor default operating_temperature in K is assumed to be 25 C = 25+273.15 = 298.15 K. The initialization value, however, was set to "25" and never converted from C to K creating a contradiction.

Set new operating_temperature init values to 298.15 across Sensor classes.
@Gui-FernandesBR
Gui-FernandesBR merged commit bf55788 into RocketPy-Team:develop Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants