Skip to content

CI: run the changelog job for pull requests from forks #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thc1006 wants to merge 1 commit into
base: develop
Choose a base branch
from
+11 −2
Open

CI: run the changelog job for pull requests from forks #1112

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,21 @@
name: Populate Changelog
on:
pull_request:
# `pull_request_target`, not `pull_request`. Secrets are withheld from a
# `pull_request` run whose head is a fork, so RELEASE_TOKEN arrived empty and
# the checkout below failed for every outside contribution.
#
# Nothing from the pull request is executed. The checkout is `ref: develop`,
# and the updater is inline below, which under this trigger is read from the
# default branch rather than from the merged head.
pull_request_target:
types: [closed]
branches:
- develop

# Read, because the job's own writes go through RELEASE_TOKEN. This trigger runs
# with secrets available, so GITHUB_TOKEN should not also carry write.
permissions:
contents: write
contents: read

jobs:
Changelog:
Expand Down