Full rebuild August 2026 bump ros2-distro-mutex to 0.19.0 and build number to 24 - #31
Full rebuild August 2026 bump ros2-distro-mutex to 0.19.0 and build number to 24#31mini-1235 wants to merge 35 commits into
Conversation
|
I need newer versions of some packages, so I asked my agent to help prepare this PR. I will mark it as ready once all checks are green and I have completed a self review |
Great thanks! I think @Tobias-Fischer contributed a lot of patches upstream in this period (see RoboStack/robostack.github.io#16). I am not sure how many of those have been actually merged and released, but I guess this is an information that could be useful as context for your agents. |
|
Hi @traversaro, during a local full rebuild of The package builds with C++20 and uses
The build fails because libc++’s Representative error: Would it be possible to raise the macOS deployment target for Rolling to at least ros-rolling/conda_build_config.yaml Line 62 in b1cd6ac Or are there any alternatives that you would suggest? |
|
Related PR ros/resource_retriever#123 |
Ok for me, but @Tobias-Fischer is more the macOS expert. |
|
OK for me, too, thanks! let’s also make use of RoboStack/vinca#104 |
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
|
@Tobias-Fischer After some local testing, I think we also need to bump Vinca’s OSX_DEPLOYMENT_TARGET to 13.3 in the generated build templates, for example here: Does that sound right before I open a Vinca PR? |
|
We should be able to simply remove it these days |
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Tobias-Fischer
left a comment
There was a problem hiding this comment.
Amazing work, many thanks for this!!
|
unvendor iceoryx is preferable, same as ros-lyrical full rebuild PR. |
I will take a look this Sunday |
| additional_cmake_args: "-DCMAKE_WINDOWS_EXPORT_ALL_SYMBOLS=ON" | ||
| uncrustify_vendor: | ||
| additional_cmake_args: "-DAMENT_VENDOR_POLICY=NEVER_VENDOR_IGNORE_SATISFIED_CHECK" | ||
| ur_calibration: |
There was a problem hiding this comment.
I am running into this because the ur_* packages set the CMake version to 3.28 and CXX_STANDARD to 20. On macOS, that causes a clang-scan-deps not found error during compilation:
My current workaround feels more like a hack than a proper solution. Another approach I tried was installing clang_tools and explicitly setting:
ur_calibration:
additional_cmake_args: "-DCMAKE_CXX_COMPILER_CLANG_SCAN_DEPS=$BUILD_PREFIX/bin/clang-scan-deps"That works as well, but it also feels like a workaround rather than a long-term fix, especially since more packages will likely start requiring CMake 3.28+ over time.
Any suggestions? @traversaro @Tobias-Fischer @wep21
There was a problem hiding this comment.
How about adding clang-tools to the build deps on osx be default in vinca?
/cc @ruben-arts how do you deal with this in pixi-build-ros?
There was a problem hiding this comment.
I give it a try in RoboStack/vinca#133, let me know what you think
There was a problem hiding this comment.
I don't think we're depending on it by default.
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
|
Per RoboStack/vinca#133 (comment), unpin cmake now and see how it goes |
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
|
@traversaro I am hitting the following error after updating the CMake version: https://github.com/RoboStack/ros-rolling/actions/runs/31511802074/job/93847194492?pr=31 I tried searching around a bit, but I still don't quite understand why this would be related to the CMake version. The same package was building successfully before the CMake update. Does this error look familiar to you? |
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
The Why this is happening only for newer version of CMake? I am not sure, but probably there were some fixes in some recent release of CMake that exposed with The possible fixes are either one of the following:
I think F1 is the more clean solution, and also more aligned with how both ROS and the rest of the Gazebo libraries are handling this. Given the amount of files touched by this, it would be quite hard to mantain this as robostack patch, so it is better to do the fix upstream as much as possible. |
|
Thanks for the detailed explanation, I really appreciate it! I can take another look at this PR over the weekend. By the way, do you know of any good way to run the Windows build on macOS so I can reproduce the issue locally instead of relying on CI for testing? |
Summary
Validation
Full package rebuild is intended to run in CI.