design: governance voting UI with tally and confirmation - #670
Open
Killerjunior wants to merge 1 commit into
Open
Killerjunior wants to merge 1 commit into
Killerjunior wants to merge 1 commit into
Conversation
|
@Killerjunior Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the Governance Voting UI for token-holder proposals across
src/components/OfferingDetail.tsxunder the#governancetab. Enables token holders to inspect proposal context, track quorum achievement, review vote tallies with color-blind accessible visualizations, assess voting power, and cast votes through an accessible confirmation modal flow with retry capabilities.Closes #629
Root Cause / Motivation
Token holders had no unified, accessible interface within an offering's details to review on-chain governance proposals, assess quorum progress, and submit their votes. Proposals require accessible tally displays (WCAG 2.1 AA compliant for color-blind users), clear voting power summaries, and safe transaction confirmation dialogs that prevent double-submissions and allow error recovery.
Solution Details
src/components/GovernanceVoting/):active,pre_voting,passed,rejected,quorum_failed), category tags, and timeline countdowns..gv-bar--for,.gv-bar--against,.gv-bar--abstain), numeric percentages, token amounts, and ansr-onlyfallback table.aria-live="polite") announcing vote tally changes to screen readers.For,Against,Abstain) with arrow key navigation and defensive disablement.Escapekey close, focus restoration, double-submit protection, and error recovery with an inline retry action.src/components/OfferingDetail.tsx):"governance"tab toSETTINGS_TABSandrenderPanelContent.general,distributions,compliance,documents,danger).docs/uiux/governance-proposal-detail.md):Testing Steps
npx vitest run src/components/GovernanceVoting/GovernanceVoting.test.tsx src/components/OfferingDetail.test.tsx.jest-axechecks.http://localhost:5173/offerings/1#governancein a browser.For,Against,Abstain) and click Review & Cast Vote.Escape, and submits successfully, updating the tally.CI Checklist
anyor placeholders.OfferingDetailtabs and routing.