update dependencies and CI, fixes - #36
Open
johguenther wants to merge 8 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Prepares the v2.0.3 release by updating project/release metadata, refreshing the Embree dependency used by the superbuild, and addressing a Windows/MSVC enum-size issue (with a regression test) alongside Windows CI/release tooling updates.
Changes:
- Bump version references to 2.0.3 across CMake, README, changelog, and release workflow.
- Update superbuild Embree dependency to v4.4.1 (URLs/hashes).
- Adjust several public enums to use explicit underlying types in C++ builds and add a unit test validating
VKLUnstructuredCellTypesize; update Windows build/release workflows to drop explicit toolset selection and move release builds to VS2022.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
testing/apps/tests/enum.cpp |
Adds a Catch2 test to validate VKLUnstructuredCellType size. |
testing/apps/CMakeLists.txt |
Registers the new enum test in the test executable. |
superbuild/CMakeLists.txt |
Bumps Embree to v4.4.1 and updates download hashes. |
README.md |
Updates release version text and adds v2.0.3 notes. |
openvkl/include/openvkl/volume.h |
Forces underlying type for selected enums in C++ builds (incl. VKLUnstructuredCellType). |
openvkl/include/openvkl/VKLTemporalFormat.h |
Adjusts enum underlying-type selection for C++ builds. |
openvkl/include/openvkl/VKLLogLevel.h |
Adjusts enum underlying-type selection for C++ builds. |
openvkl/include/openvkl/VKLFormat.h |
Adjusts enum underlying-type selection for C++ builds. |
openvkl/include/openvkl/VKLFilter.h |
Adjusts enum underlying-type selection for C++ builds. |
openvkl/include/openvkl/VKLError.h |
Adjusts enum underlying-type selection for C++ builds. |
openvkl/include/openvkl/VKLDataType.h |
Adjusts enum underlying-type selection for C++ builds. |
openvkl/include/openvkl/data.h |
Adjusts enum underlying-type selection for C++ builds. |
doc/overview.md |
Updates platform/support wording (removes “beta” mention). |
CMakeLists.txt |
Bumps project version to 2.0.3. |
CHANGELOG.md |
Adds v2.0.3 entries for enum-size fix and Embree update. |
.github/workflows/internal.release.yml |
Bumps release package version; updates Windows release generator usage (drops toolset, VS2022). |
.github/workflows/internal.nightly.windows.yml |
Updates Windows nightly build invocation to drop explicit toolset argument. |
.github/workflows/internal.ci.windows.yml |
Updates Windows CI build invocations to drop explicit toolset argument. |
.github/scripts/release/windows.ps1 |
Removes passing an explicit CMake toolset (-T). |
.github/scripts/build.bat |
Removes passing an explicit CMake toolset (-T) and shifts argument usage. |
.github/deps/gfx-windows-public.env |
Unpins Windows GPU driver version to windows-latest. |
.github/deps/dpcpp-sycl-nightly.env |
Changes SYCL nightly compiler version reference. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
johguenther
force-pushed
the
guj/fixes
branch
4 times, most recently
from
April 2, 2026 16:02
88b49ef to
1ecad44
Compare
- oneTBB v2023.1 - dpcpp v7.0.0, latest Windows GPU driver - Dear ImGui v1.92.9b, no longer in-source - glfw v3.5.1 - OpenVDB v13.0.0 - drop IlmBase (not needed anymore) - Boost v1.91.0
workaround dpcpp 7 hang when compiling imgui_internal.h
- not as submodule, but via CMake ExternalProject - fix compilation on Windows - include in Windows release
Embree ships with TBB, but superbuild's TBB should be preferred
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.