Conversation
The pom did not pin maven-surefire-plugin, so Maven's default 2.12.4 ran zero tests: the JUnit 5 suite had never executed in CI. Pinning surefire 3.2.5 exposed 20 broken tests, which in turn surfaced a real bug. module-info.java did not open the generated DTO package to Jackson, so on the module path every readValue() threw InaccessibleObjectException. That exception is swallowed in mapException(), collapsing every API error into a generic BadRequestException instead of InvalidJsonException, TooManyTermsException, QuotaExceededException and friends. The remaining failures were stale assertions: Optional-returning getters compared with isEqualTo, a Python-style Term repr, and Mockito stubs on overloads the client no longer calls. Mockito is bumped to 5.20 so the build also works on current JDKs. Consistency with the other two SDKs: - maven.yml -> ci.yml, named CI, triggered on main, Java matrix now includes 11 (the documented and published minimum) - publish.yml runs tests before deploying, imports the GPG key with GPG_PASSPHRASE (GPG_SIGNING_PASSPHRASE was never defined), uses setup-java@v4 and drops the -P release profile absent from the pom - README: options paragraph now describes OperationOptions, the only options type this SDK has; installation layout, ResponseFormat.ANY note and typo fix aligned with the JS and Python READMEs - executionTimeout javadoc said seconds; the API takes milliseconds - dropped the unused generated copy of openapi.yaml and rewrote .gitignore in the shared layout Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.