Freeze Grenade can unexpectedly freeze marines that have been knocked out and incapacitated.

[IAFCrash]

To test, we can set these convars below:

rd_allow_revive 1
asw_skill_grenades_freeze_duration_base 100

Now kill a marine ( makes it incapacitated ), and then throw the marine a freeze grenade, and finally revive the marine.
And now you can see the marine is frozen.

[IAFCrash]

Maybe we also need to test this with extinguisher and sentry_top_icer (CASW_Extinguisher_Projectile) when rd_extinguisher_freeze_amount is not 0?

[IAFCrash]

To test, we can set these convars below:

rd_allow_revive 1
asw_skill_grenades_freeze_duration_base 100

Now kill a marine, and then throw the marine a freeze grenade, and finally inhabit the marine. And now you can see the marine is frozen.

Additionally, if a marine throws a freeze grenade and then becomes incapacitated before the freeze grenade explodes, the freeze grenade can freeze all the marines( including incapacitated marines, they will be frozen after being revived ).

[anf3is]

I guess marines don't freeze each other if the faction of the attacker likes the "defender".

reactivedrop_public_src/src/game/shared/swarm/asw_gamerules.cpp

Lines 7038 to 7039 in faeb5c1

	if ( !ASWDeathmatchMode() && ( !pAttacker || ( pAttackerMarine && pAttackerMarine->IRelationType( pEntity ) == D_LI ) ) )
	continue;

The thing is, incapacitated marines change their faction to neutral.

reactivedrop_public_src/src/game/server/swarm/asw_marine.cpp

Line 4784 in faeb5c1

ChangeFaction( FACTION_NEUTRAL );

Relationships, if you're interested

reactivedrop_public_src/src/game/shared/swarm/asw_gamerules.cpp

Lines 4608 to 4610 in faeb5c1

	CAI_BaseNPC::SetDefaultFactionRelationship(FACTION_MARINES, FACTION_MARINES, D_LIKE, 0 );
	CAI_BaseNPC::SetDefaultFactionRelationship(FACTION_MARINES, FACTION_BAIT, D_NEUTRAL, 0 );
	CAI_BaseNPC::SetDefaultFactionRelationship(FACTION_MARINES, FACTION_NEUTRAL, D_NEUTRAL, 0 );

reactivedrop_public_src/src/game/shared/swarm/asw_gamerules.cpp

Lines 4621 to 4622 in faeb5c1

	CAI_BaseNPC::SetDefaultFactionRelationship(FACTION_NEUTRAL, FACTION_NEUTRAL, D_NEUTRAL, 0 );
	CAI_BaseNPC::SetDefaultFactionRelationship(FACTION_NEUTRAL, FACTION_MARINES, D_NEUTRAL, 0 );

---

Possible fixes for the issue:

• Do not freeze a marine if we do not hate them.
  However, I don't know how that could affect the traitors addon or other places.

• Add new faction for incapacitated marines.

• Tweak CASW_Marine::IRelationType

[dragokas]

@IAFCrash I'm against "fixing" this issue.

This is long-time behavior. Making grenade not to freezing incapacitated marine will cause significant change in gameplay balance: it will make the gameplay much more easier.

As a long-time player, I can see this change as very significant. The old behavior, where a player remains frozen after being revived, forces them to think, choose different tactics, and consider every move. If we "fix" this freezing, the player no longer has to think, no longer has to choose the right moment to revive, he can just "spam" with grenades, revive all players, and they will survive with almost 100% chance having a lot (too much) of time to defend.

[anf3is]

As it stands right now, this is clearly unintuitive behavior.

Besides, you would use up your useful extra if you want to revive your fellow marines more easily.
But I guess scarcity and resource management is not a thing on some challenges like potato.

Could add something to let challenge makers to adjust the difficulty, since rd_allow_revive is used in challenges anyway.
For example rd_allow_revive_alive_are_friendly and rd_allow_revive_dead_are_friendly with defaults set to 1.

"Prevent alive marines from damaging and inflicting status effects (like freeze) to incapacitated marines."
"Prevent incapacitated marines from damaging and inflicting status effects (like freeze) to alive marines."

[dragokas]

"Prevent alive marines from damaging and inflicting status effects (like freeze) to incapacitated marines."
"Prevent incapacitated marines from damaging and inflicting status effects (like freeze) to alive marines."

Thank you, ConVar adjustable behavior could be the ideal choice.
But the proposed ConVar names are not intuitive.

[IAFCrash]

As a long-time player, I can see this change as very significant. The old behavior, where a player remains frozen after being revived, forces them to think, choose different tactics, and consider every move. If we "fix" this freezing, the player no longer has to think, no longer has to choose the right moment to revive, he can just "spam" with grenades, revive all players, and they will survive with almost 100% chance having a lot (too much) of time to defend.

@dragokas Most players are used to throwing freeze grenades at marines surrounded by aliens, because under the default rules, a freeze grenade will not freeze an alive marine, and they may regard this as a default physical property (just like the tesla gun). However, if they are playing under the rd_allow_revive 1 rule, they will most likely be confused why the freeze grenade behaves differently depending on the marine's living status. The point is, in my view, a freeze grenade should either be able to freeze a marine at all times, or has no effect on marines at all times, and should not abruptly behaves differently based on the marine's living status.

[dragokas]

Most players are used to throwing freeze grenades at marines surrounded by aliens, because under the default rules, a freeze grenade will not freeze an alive marine, and they may regard this as a default physical property (just like the tesla gun). However, if they are playing under the rd_allow_revive 1 rule, they will most likely be confused why the freeze grenade behaves differently depending on the marine's living status. The point is, in my view, a freeze grenade should either be able to freeze a marine at all times, or has no effect on marines at all times, and should not abruptly behaves differently based on the marine's living status.

@IAFCrash yes, I understand that's a counter-intuitive, but that's already a quite long-term behaviour, and players are used to it, to choose a suitable game timing strategy (throwing grenade preferrably only after reviving the player) instead of mindlessly "spamming" with grenades that is a way much more easy to do, lower the overall gameplay difficulty. ConVar controllable option would be excellent to resolve this dispute.

I have one more question (maybe unrelated), but similar illogic happen when you put freeze turret. This turret can freeze other players, however, it never freeze player who set up turret. That's where fix is definitely needed.