Skip to content

Print Mayer bond orders in Gaussian jobs - #952

Open
kfir4444 wants to merge 1 commit into
mayer_bond_orders_parserfrom
mayer_bond_orders_g16_route
Open

Print Mayer bond orders in Gaussian jobs#952
kfir4444 wants to merge 1 commit into
mayer_bond_orders_parserfrom
mayer_bond_orders_g16_route

Conversation

@kfir4444

Copy link
Copy Markdown
Collaborator

Stack 2/5 — based on #951, review that one first.

What

IOp(2/9=2000)IOp(2/9=2000,6/80=1) in the Gaussian route section.

Why

6/80=1 makes Gaussian print the Mayer atomic bond orders that #951 parses. It is a post-SCF population analysis and its cost is negligible. Orca prints the same analysis by default, so there is no equivalent change on that side.

Making it unconditional rather than opt-in means every Gaussian log ARC produces from here on can be used for connectivity perception, including the IRC endpoint optimizations in the later PRs of this stack.

Note for reviewers

This changes every Gaussian input ARC writes, which is why 25 expected route strings in gaussian_test.py change with it. The expected values changed because the generator deliberately changed — no assertion was relaxed to accommodate new behaviour, and the change is a single token in one template line.

arc/job/adapters/psi_4.py carries a copied Gaussian-style route line containing the same IOp(2/9=2000). It was deliberately left alone as out of scope.

Testing

pytest arc/job/ — 985 passed, 3 failed. All three failures (test_which, two xTB tests) are environment-dependent and reproduce on main.

🤖 Generated with Claude Code

@kfir4444
kfir4444 force-pushed the mayer_bond_orders_g16_route branch from 38df498 to 6146de7 Compare August 10, 2026 09:09
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (mayer_bond_orders_parser@3e0e0c0). Learn more about missing BASE report.

Additional details and impacted files
@@                     Coverage Diff                     @@
##             mayer_bond_orders_parser     #952   +/-   ##
===========================================================
  Coverage                            ?   63.62%           
===========================================================
  Files                               ?      114           
  Lines                               ?    38443           
  Branches                            ?    10052           
===========================================================
  Hits                                ?    24461           
  Misses                              ?    11061           
  Partials                            ?     2921           
Flag Coverage Δ
functionaltests 63.62% <ø> (?)
unittests 63.62% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant