Skip to content

Add some new "status quo" atime tests for common operations #4517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jangorecki wants to merge 21 commits into
base: master
Choose a base branch
from
+33 −0
Open

Add some new "status quo" atime tests for common operations #4517

Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
50e61e0
build and install stuff
jangorecki May 28, 2020
1c7e6c4
rename to cc
jangorecki May 28, 2020
4421958
initial internal framework for benchmarking
jangorecki May 28, 2020
3a55ef0
forder benchmark
jangorecki May 29, 2020
ea15862
always run many threads
jangorecki May 30, 2020
b0db59c
automate cflags
jangorecki May 30, 2020
7c76529
minor improvements
jangorecki May 30, 2020
bc8a8be
allow loop over various R builds
jangorecki May 30, 2020
7870a50
Merge branch 'master' into benchmark
jangorecki Oct 6, 2020
a3500bd
simplify benchmarks
jangorecki Oct 9, 2020
d40f0cb
remove unused anymore
jangorecki Oct 9, 2020
bea4feb
reduce diff
jangorecki Oct 9, 2020
4fe8676
roadmap for more checks
jangorecki Oct 9, 2020
39843be
fix coverage
jangorecki Oct 9, 2020
8ff16c9
Merge branch 'master' into benchmark
MichaelChirico Jul 16, 2025
9e871d4
Convert a few to atime tests
MichaelChirico Jul 16, 2025
97c6ff4
revert
MichaelChirico Jul 16, 2025
3b29aa7
missing ','
MichaelChirico Jul 16, 2025
319280b
bad copy-paste
MichaelChirico Jul 16, 2025
73efaf3
missing 'data.table::'
MichaelChirico Jul 16, 2025
5e36044
Merge branch 'master' into benchmark
ben-schwen Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions .ci/atime/tests.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,39 @@ test.list <- atime::atime_test_list(
Fast = "ed2df986da6d3a4ff35bec1b0f75db2b767e3eb2", # Merge commit of the PR that uses a much faster implementation
expr = data.table::isoweek(x)),

"GForce aggregation (benchmark across # rows)" = atime::atime_test(
setup = {
set.seed(34893)
DT = data.table(grp = sample.int(10L, N, TRUE), v=rnorm(N), i=sample(N), vna=rnorm(N))
DT[1:3, vna := NA_real_]
},
expr = data.table:::`[.data.table`(DT, j=.(mean(v), sum(v), mean(i), sum(i), mean(vna, na.rm=TRUE), sum(vna, na.rm=TRUE))),

@ben-schwen ben-schwen Aug 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't we need a by for GForce to kick in?

`Status quo` = "8f5ffa8bb8f3f5861020a6e32f897c30e42eeab0"), # Parent of the first commit in the PR (https://github.com/Rdatatable/data.table/commit/8f5ffa8bb8f3f5861020a6e32f897c30e42eeab0)

"GForce aggregation (benchmark across # groups)" = atime::atime_test(
setup = {
set.seed(34893)
DT = data.table(grp = sample.int(1e7, N, TRUE), v=rnorm(1e7), i=sample(1e7), vna=rnorm(N))
},
expr = data.table:::`[.data.table`(DT, j=.(mean(v), sum(v), mean(i), sum(i), mean(vna, na.rm=TRUE), sum(vna, na.rm=TRUE))),

@ben-schwen ben-schwen Aug 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

`Status quo` = "8f5ffa8bb8f3f5861020a6e32f897c30e42eeab0"), # Parent of the first commit in the PR (https://github.com/Rdatatable/data.table/commit/8f5ffa8bb8f3f5861020a6e32f897c30e42eeab0)

"Serial value setting with :=" = atime::atime_test(
setup = {
set.seed(34893)
DT = data.table(i=N:1)
},
expr = for (ii in seq_len(nrow(DT))) data.table:::`[.data.table`(DT, ii, `:=`(i, ii)),
`Status quo` = "8f5ffa8bb8f3f5861020a6e32f897c30e42eeab0"), # Parent of the first commit in the PR (https://github.com/Rdatatable/data.table/commit/8f5ffa8bb8f3f5861020a6e32f897c30e42eeab0)

"Serial value setting with set" = atime::atime_test(
setup = {
set.seed(34893)
DT = data.table(i=N:1)
},
expr = for (ii in seq_len(nrow(DT))) data.table::set(DT, ii, "i", ii),
`Status quo` = "8f5ffa8bb8f3f5861020a6e32f897c30e42eeab0"), # Parent of the first commit in the PR (https://github.com/Rdatatable/data.table/commit/8f5ffa8bb8f3f5861020a6e32f897c30e42eeab0)

# Regression introduced by https://github.com/Rdatatable/data.table/pull/6890 and discussed in https://github.com/Rdatatable/data.table/issues/7404 (grouped by factor).
"DT[by] max regression fixed in #7480" = atime::atime_test(
setup = {
Expand Down
Loading