Skip to content

[TEST] TC-6192 verify-pr E2E acceptance vehicle - #300

Closed
mrizzi wants to merge 3 commits into
verify-pr-fullsendfrom
tc-6192-e2e-acceptance
Closed

mrizzi wants to merge 3 commits into
verify-pr-fullsendfrom
tc-6192-e2e-acceptance

Conversation

@mrizzi

@mrizzi mrizzi commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Throwaway PR to exercise the CI-gated verify-pr dispatch end-to-end (TC-6192).

The qualifying Jira task carries the ai-generated-jira label, is in Review, and points its Git Pull Request field at this PR. Used to confirm: dispatch waits for CI, verify-pr runs after CI finishes (pass and fail), report posts to PR + Jira, and no duplicate reports on re-run.

Safe to close/delete after TC-6192.

Implements TC-6192

Summary by Sourcery

Add temporary TC-6192 acceptance scaffolding to exercise verify-pr dispatch and reporting after CI failure.

Documentation:

  • Add documentation identifying the temporary TC-6192 end-to-end acceptance vehicle.

Tests:

  • Add temporary acceptance-test scaffolding covering verify-pr behavior when CI fails.

Chores:

  • Add disposable scaffolding for the TC-6192 verify-pr end-to-end acceptance exercise.

Throwaway scaffolding to exercise the CI-gated verify-pr dispatch
end-to-end. Safe to delete after TC-6192.

Implements TC-6192

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Assisted-by: Claude Code
@sourcery-ai

sourcery-ai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This throwaway PR adds a six-line E2E acceptance-test document used as the vehicle for validating CI-gated verify-pr dispatch, including successful and failed CI paths, PR/Jira reporting, and duplicate-report prevention on reruns; it contains no production code or workflow changes.

Sequence diagram for CI-gated verify-pr acceptance flow

sequenceDiagram
    actor Maintainer
    participant Jira
    participant PR
    participant CI
    participant VerifyPR

    Maintainer->>Jira: Qualify task
    Jira->>PR: Link Git Pull Request
    PR->>CI: Run CI
    CI-->>PR: CI finishes
    PR->>VerifyPR: Dispatch verify-pr
    VerifyPR->>PR: Post report
    VerifyPR->>Jira: Post report
    Maintainer->>VerifyPR: Re-run verify-pr
    VerifyPR-->>PR: Avoid duplicate report
    VerifyPR-->>Jira: Avoid duplicate report
Loading

File-Level Changes

Change Details Files
Adds a disposable documentation marker for the TC-6192 verify-pr end-to-end acceptance workflow.
  • Documents the qualifying PR-to-CI-to-verify-pr reporting flow.
  • Marks the file and associated PR as safe to remove after acceptance testing.
docs/e2e/tc-6192-vehicle.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai Bot previously approved these changes Sep 15, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 15, 2026

Copy link
Copy Markdown

🤖 Finished Verify Pr · ⏭️ Skipped (no Jira issue links PR #300 in its Git Pull Request field) · Started 3:41 PM UTC · Completed 3:41 PM UTC

Commit: 4c1b71d · View workflow run →

Effort: high

Empty commit to re-fire the qualifying dispatch after the Jira Git Pull
Request field index caught up (TC-6254 -> PR #300).

Implements TC-6192

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Assisted-by: Claude Code
@fullsend-ai-review

fullsend-ai-review Bot commented Sep 15, 2026

Copy link
Copy Markdown

🤖 Finished Verify Pr · ✅ Success · Started 3:46 PM UTC · Completed 3:54 PM UTC

Commit: 3271577 · View workflow run →

Runtime: claude · Model: claude-opus-4-8 · Effort: high · Cost: $3.10

@fullsend-ai-review

Copy link
Copy Markdown

Verification Report for TC-6254 (commit 3271577)

Check Result Details
Review Feedback N/A No inline review comments and no substantive review-body feedback (sole review is a sourcery-ai approval).
Root-Cause Investigation N/A No sub-tasks created; nothing to investigate.
Scope Containment PASS Created file docs/e2e/tc-6192-vehicle.md matches the file named in the acceptance criterion; no out-of-scope or unimplemented files.
Diff Size PASS 1 file, 6 insertions, 0 deletions — proportionate for a doc-scaffolding task.
Commit Traceability WARN 1 of 2 commits references TC-6254; both carry an Implements TC-6192 trailer (sibling umbrella task).
Sensitive Patterns PASS No secrets, keys, or credentials in added lines.
CI Status PASS No CI failures evident; verify-pr dispatch fired post-CI-gate (direct CI polling unavailable in sandbox).
Acceptance Criteria PASS 1 of 1 criteria met — the note exists and states it is safe to delete after TC-6192.
Test Quality N/A No test files in the PR; Eval Quality: N/A (no eval result reviews).
Test Change Classification N/A No test files added, modified, or deleted.
Verification Commands N/A No verification commands specified and no eval infrastructure changes.

Overall: WARN

Overall WARN — the only non-PASS check is Commit Traceability: commit 4c1b71d references only the sibling umbrella task TC-6192 (Implements TC-6192) and not this task TC-6254, while commit 3271577 mentions both. This is informational and does not block. The PR otherwise satisfies its single acceptance criterion, contains no secrets, and shows no CI failures. No code change requests were raised, so no sub-tasks were created. Merging remains a human decision.


This comment was AI-generated by sdlc-workflow/verify-pr v0.13.9.

Drives python-tests to a failure conclusion so verify-pr can be observed
running post-CI despite failure (CI result is data, not a gate). Throwaway;
safe to delete after TC-6192.

Implements TC-6192

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Assisted-by: Claude Code
@sourcery-ai
sourcery-ai Bot dismissed their stale review September 15, 2026 15:57

Sourcery withdrew this approval because the latest commits introduced blocking findings.

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 15, 2026

Copy link
Copy Markdown

🤖 Finished Verify Pr · ✅ Success · Started 3:58 PM UTC · Completed 4:08 PM UTC

Commit: 64b818c · View workflow run →

Runtime: claude · Model: claude-opus-4-8 · Effort: high · Cost: $4.33

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 15, 2026

Copy link
Copy Markdown

Verification Report for TC-6254 (commit 64b818c)

Check Result Details
Review Feedback N/A No inline review comments and no substantive review-body feedback (sole review is a sourcery-ai[bot] approval).
Root-Cause Investigation N/A No new sub-tasks created this run (the sole CI failure is already tracked by existing sub-task TC-6255); nothing to investigate.
Scope Containment WARN Task-required file docs/e2e/tc-6192-vehicle.md present; one justified out-of-scope test file (test_tc6192_ci_fail.py) added to exercise the CI-fail path.
Diff Size PASS 17 insertions across 2 files — proportionate to a scaffolding task.
Commit Traceability WARN Only 1 of 3 commits references task ID TC-6254; the other two reference the parent TC-6192.
Sensitive Patterns PASS No sensitive patterns detected in 17 added lines across 2 files.
CI Status FAIL python-tests check failed on the intentional assert False test (deliberate CI-fail acceptance scenario; already tracked by TC-6255).
Acceptance Criteria PASS 1 of 1 criteria met — docs/e2e/tc-6192-vehicle.md exists with the required description and deletion note.
Test Quality PASS Repetitive tests: none; test doc comments present; Eval Quality: N/A.
Test Change Classification ADDITIVE One new test file added; no modified/deleted tests.
Verification Commands N/A No verification commands specified; PR touches no eval infrastructure.

Overall: FAIL

The PR satisfies its single acceptance criterion (the docs/e2e/tc-6192-vehicle.md note describing the throwaway acceptance vehicle and stating it is safe to delete after TC-6192), contains no secrets, and adds test coverage additively. Overall is FAIL solely because the python-tests CI check fails — by design: this throwaway E2E vehicle deliberately adds an always-failing test (test_tc6192_intentional_failure) to exercise verify-pr's post-CI-failure dispatch (CI result is data, not a gate for this vehicle). That failure is already tracked by sub-task TC-6255 (created on a prior verify-pr run for this same commit), so no new sub-task was created this run. Two informational WARNs: Scope Containment includes one justified out-of-scope test file, and Commit Traceability references the parent TC-6192 rather than TC-6254 in 2 of 3 commits. This skill does not merge or transition the issue — a human reviewer decides on merge; the vehicle files are safe to delete after TC-6192.


This comment was AI-generated by sdlc-workflow/verify-pr v0.13.9.

Previous run

Verification Report for TC-6254 (commit 64b818c)

Check Result Details
Review Feedback N/A No inline review comments; the sole review is a sourcery-ai[bot] approval with no substantive feedback.
Root-Cause Investigation SKIPPED 1 CI-failure sub-task created, but the failure is intentional E2E throwaway scaffolding — no preventable workflow-phase or convention gap, so no root-cause task was created.
Scope Containment WARN Required file docs/e2e/tc-6192-vehicle.md present; one extra file plugins/sdlc-workflow/scripts/test_tc6192_ci_fail.py is justified CI-fail scaffolding.
Diff Size PASS 2 files, +17/-0 — proportional to a throwaway docs + scaffolding task.
Commit Traceability WARN 1 of 3 commits references TC-6254; the other two reference TC-6192 (parent E2E effort).
Sensitive Patterns PASS No secrets, credentials, keys, or sensitive files in any added line.
CI Status FAIL python-tests fails: test_tc6192_intentional_failure in test_tc6192_ci_fail.py does assert False (intentional).
Acceptance Criteria PASS 1 of 1 criteria met — docs/e2e/tc-6192-vehicle.md describes the throwaway vehicle and states it is safe to delete after TC-6192.
Test Quality PASS Repetitive Test PASS; Test Documentation PASS (module + function docstrings); Eval Quality: N/A.
Test Change Classification ADDITIVE Only a new test file added; no test coverage removed or weakened.
Verification Commands N/A No task-specified verification commands and no eval infrastructure changes detected.

Overall: FAIL

CI Status is FAIL: PR #300 introduces test_tc6192_ci_fail.py whose test_tc6192_intentional_failure always fails, driving the python-tests check to a failure conclusion by design (this is a TC-6192 E2E acceptance vehicle demonstrating that verify-pr still runs and posts despite CI failure — CI result is data, not a gate). A CI-failure sub-task was created to track removing the throwaway test. Scope Containment and Commit Traceability are WARN (justified extra scaffolding file; commits reference TC-6192 rather than TC-6254). Root-Cause Investigation was SKIPPED — the failure is intentional, self-documented scaffolding with no preventable systemic gap. All other checks PASS or N/A. Merging remains a human decision; this report is informational.


This comment was AI-generated by sdlc-workflow/verify-pr v0.13.9.

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 15, 2026

Copy link
Copy Markdown

🤖 Finished Verify Pr · ✅ Success · Started 4:12 PM UTC · Completed 4:21 PM UTC

Commit: 64b818c · View workflow run →

Runtime: claude · Model: claude-opus-4-8 · Effort: high · Cost: $3.97

@mrizzi

mrizzi commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator Author

Closing — this was the disposable E2E acceptance vehicle for TC-6192. The run evidence is permanent (workflow run IDs + these report comments persist) and is recorded in fullsend.md via PR #301. Safe to close and delete the branch.

@mrizzi mrizzi closed this Sep 15, 2026
@mrizzi
mrizzi deleted the tc-6192-e2e-acceptance branch September 15, 2026 16:27
mrizzi added a commit that referenced this pull request Sep 16, 2026
Add fullsend.md §Acceptance run → "E2E acceptance via CI dispatch
(TC-6192)" documenting the CI-gated verify-pr dispatch proven end to end
on PR #300 / TC-6254: qualifying PR triggers the workflow, wait-for-checks
releases after CI reaches terminal, verify-pr posts to both the PR and
Jira. Records all four acceptance criteria — CI-pass run (python-tests
success → Overall WARN), CI-fail run (python-tests failure still releases
the wait → CI Status FAIL, sub-task auto-created), report on both surfaces,
and idempotency (re-run same head, no duplicate reports). Notes DENIED
egress = split-trust policy working, and the interim personal-token Jira
authorship pending the SA (TC-6191).

Implements TC-6192

Assisted-by: Claude Code
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant