Skip to content

fix(lifecycle): require source_revision on daily monitor snapshots - #615

Merged
Pigbibi merged 3 commits into
mainfrom
fix/lifecycle-snapshot-source-revision-20260918
Sep 18, 2026
Merged

Pigbibi merged 3 commits into
mainfrom
fix/lifecycle-snapshot-source-revision-20260918

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Require real source_revision when writing daily performance snapshots.
  • Wire --source-revision \"\${GITHUB_SHA}\" in reusable drift-check monitor step.
  • Fail closed on missing provenance instead of writing empty strings that look like complete observations.

Test plan

  • tests/test_lifecycle_performance_monitor.py
  • After merge: re-run drift-check monitor to overwrite empty GCS daily revisions (does not clear CRITICAL by itself)

Made with Cursor

Pigbibi and others added 3 commits September 19, 2026 01:47
Empty provenance previously made probes report observation_source_unavailable
while Policy A still retained CRITICAL. Fail closed unless a real revision is
supplied via argument, LIFECYCLE_SOURCE_REVISION, or GITHUB_SHA.

Co-authored-by: Cursor <cursoragent@cursor.com>
…orkflow

Co-authored-by: Cursor <cursoragent@cursor.com>
@Pigbibi
Pigbibi merged commit 2cf1798 into main Sep 18, 2026
1 check passed
@Pigbibi
Pigbibi deleted the fix/lifecycle-snapshot-source-revision-20260918 branch September 18, 2026 17:57
Pigbibi added a commit that referenced this pull request Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant