fix: retain sanitized keepalive failure stages - #144
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scheduled keepalive can fail after SSH is restored but before the recovery script emits a stage. Those failures were reported only as REMOTE_COMMAND_OR_TRANSPORT_FAILED, preventing attribution from the retained workflow log.
Add allowlisted stage markers to the existing remote keepalive command and consume them in the existing sanitized classifier. Preserve recovery-stage precedence and the generic fallback for transport/unknown errors. Keep raw command output private and transient; preserve the original watcher cleanup activation point, maintenance commands, retries and failure exit status.
Validation: focused shell regression passed (confirmed RED on the old base), including stage classification/redaction, transport fallback, pipe failure, successful exit, and original watcher cleanup timing/exit status. Actionlint, Python test (1 passed) and diff checks passed. Seven other shell test scripts passed. The recovery shell test fails on both unchanged base and this branch in the local macOS environment, which lacks flock/timeout; required Linux CI must pass before merge. No manual maintenance, VM reset, authentication or broker operation was triggered for this patch. A later natural run is required to identify the production failure stage; this change does not claim Gateway recovery.