fix: reconcile stable position quantities instead of valuations - #315
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compatibility / safety
This changes the meaning of positions_sha256 from a raw-payload digest to a stable accounting projection. Existing raw-payload baseline digests are NOT directly comparable and are NOT automatically overwritten or reinterpreted. Any replacement reference must be independently verified under existing authorization, never copied from the current observation to self-certify a match.
This patch does NOT solve the Firstrade fill-history gap. recent_executions_available remains false and candidates remain blocked. No claim of broker/account recovery, no order/provider/cloud/login/refresh operation, and no deploy/config mutation.
Verification
Scope
Exactly application/broker_reconciliation.py and tests/test_broker_reconciliation.py. Deploy Cloud Run is workflow_dispatch-only; PR/main CI does not deploy. Other PRs, baseline references and runtime configuration remain untouched.