Skip to content

fix: parse nested Cloud Run deployment readback - #313

Merged
Pigbibi merged 1 commit into
mainfrom
codex/firstrade-deploy-readback-parsing-20260905
Sep 5, 2026
Merged

Pigbibi merged 1 commit into
mainfrom
codex/firstrade-deploy-readback-parsing-20260905

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Root cause

The failed no-traffic run 33893273581 reported a revision readiness failure. A bounded read-only diagnosis found the revision ready and its immutable image matching the pushed digest. gcloud JSON projection retains the status envelope; treating that object as an array always returned False. The same error hashed effective traffic as an empty list. Array member projections also omitted protected configuration/IAM fields.

Minimal fix

  • Read nested status.conditions and status.traffic in the existing inline workflow.
  • Include container resources, secret references and IAM array members/conditions in the existing baseline comparison.
  • Exercise the actual inline Python using synthetic fixtures; no new framework, dependency, hash or production module.

Verification

  • Before fix: 4 failed, 9 passed.
  • After fix: focused 13 passed; full local suite 343 passed, 1 existing dependency warning.
  • Ruff, git diff --check, two shell blocks bash -n passed.
  • No deploy, traffic/config/Scheduler/IAM change, credential refresh or broker call. Required CI remains the merge gate; runtime recovery is not claimed.

Runtime stop rule

Historical deployment validation remains parked. Any new one-shot no-traffic validation requires the independent bounded Goal; this PR does not dispatch it.

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit 6d2970b into main Sep 5, 2026
1 check passed
@Pigbibi
Pigbibi deleted the codex/firstrade-deploy-readback-parsing-20260905 branch September 5, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant