Skip to content

fix: wire cached-only read-only broker reconciliation - #312

Merged
Pigbibi merged 1 commit into
mainfrom
codex/firstrade-cached-reconciliation-20260905
Sep 5, 2026
Merged

Pigbibi merged 1 commit into
mainfrom
codex/firstrade-cached-reconciliation-20260905

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Purpose

Replace the absent production reconciliation client builder with the existing SDK in a cached-session-only account-read path.

Safety

  • No password/MFA reads, login fallback, cache save/delete, quote or order requests.
  • Fresh non-trading client; finite unexpired cache, explicit account required before connection.
  • Instance-only GET allowlist, bounded timeout, redirects and ambient netrc/proxy disabled; stop on first HTTP/auth/JSON failure.
  • Close client on success and failure; retain disabled/continuity/baseline and incomplete-executions guards.
  • No runtime/config/Scheduler/provider operations. This does not establish complete reconciliation or live readiness.

Verification

  • RED: 17 absent cached-only path/builder cases; an additional account-precondition regression reproduced independently.
  • GREEN: 84 focused client/request/reconciliation tests.
  • Full local suite before the final account precondition: 335 passed (one upstream calendar deprecation warning).
  • Ruff and git diff --check passed. Required CI must pass before merge.
  • Existing SDK source independently inspected read-only; no broker connection.

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit 1b9624c into main Sep 5, 2026
1 check passed
@Pigbibi
Pigbibi deleted the codex/firstrade-cached-reconciliation-20260905 branch September 5, 2026 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant