Skip to content

fix: reject malformed broker order responses - #311

Merged
Pigbibi merged 1 commit into
mainfrom
codex/firstrade-order-read-failclosed-20260905
Sep 5, 2026
Merged

Pigbibi merged 1 commit into
mainfrom
codex/firstrade-order-read-failclosed-20260905

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Scope

  • Stop converting missing/unknown order payloads or invalid rows into empty successful order reads.
  • Preserve explicit empty lists and the existing supported wrapper shapes.
  • Propagate a fixed sanitized failure through get_order_status; no broker payload logging, dependency or schema changes.

Validation

  • RED: five malformed cases incorrectly returned success; ten valid shape cases passed.
  • GREEN: 46 focused client/reconciliation/runtime-adapter tests passed with the pinned QPK/strategy source overlay and installed firstrade 0.0.39. Ruff and diff check passed.
  • An initial broader attempt used an environment without firstrade; it was an environment failure, not a behavioral regression. No production dependency changed.

Remaining recovery limits

This does not establish account-history completeness, add the production reconciliation builder, refresh credentials, deploy, or activate trading.

Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit 0adc993 into main Sep 5, 2026
1 check passed
@Pigbibi
Pigbibi deleted the codex/firstrade-order-read-failclosed-20260905 branch September 5, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant