Skip to content

fix(execution): require durable claim before live submission - #310

Merged
Pigbibi merged 2 commits into
mainfrom
codex/firstrade-ex05-required-claim-20260905
Sep 4, 2026
Merged

Pigbibi merged 2 commits into
mainfrom
codex/firstrade-ex05-required-claim-20260905

Conversation

@Pigbibi

@Pigbibi Pigbibi commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Require enabled strategy-run persistence and a durable state store at the actual non-dry-run submission boundary.
  • Reject missing submission-claim callbacks for sell, whole-share buy and notional buy; retain legitimate no-op and dry-run preview behavior.
  • Retain permanent claims after ambiguous submission or completed-state persistence failure.
  • Correct the existing CI source-selection defect: checkout QPK/UES at uv.lock revisions, retain frozen installed packages instead of editable overrides, and run the existing QPK checker against the locked expected pin. Dependency pins and lockfile are unchanged.

Validation

  • Business regression RED: 6 expected failures / 55 passes; GREEN: 61 passes. Expanded synthetic coverage: 110 passes.
  • CI regression RED: 3 expected failures / 3 passes; combined focused GREEN: 68 passes.
  • Fresh temporary runtime installed 53 packages offline from existing cache with uv sync --frozen --extra test. uv pip check passed; installed shared direct_url identities and import smoke match exact lock revisions. Existing QPK pin checker and uv lock --offline --check passed.
  • Full local suite under a strict socket/subprocess prohibition: 292 passed; 4 existing subprocess-based env-sync-plan CLI tests were blocked by that local safety hook, not by application failures. Remote CI runs those unchanged synthetic CLI tests normally.
  • Full-repository Ruff and git diff --check passed. Six-file scope only; the original four business files were unchanged by the CI correction.

Boundaries

No broker/provider/runtime/deployment operations. Only pull-request/main-push offline CI is triggered; deploy/invoke workflows remain explicit-dispatch only. This does not establish physical-account cross-platform fencing or verify the deployed state store.

Pigbibi and others added 2 commits September 5, 2026 06:50
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
@Pigbibi
Pigbibi merged commit d73c2c8 into main Sep 4, 2026
1 check passed
@Pigbibi
Pigbibi deleted the codex/firstrade-ex05-required-claim-20260905 branch September 4, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant