Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/backtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -191,6 +191,9 @@ def run_walkforward_scoring(
prediction_frame = pd.concat(all_predictions).sort_index()
aggregated = aggregate_walkforward_predictions(prediction_frame, aggregation_mode=aggregation_mode)
panel = panel.join(aggregated, how="left")
# Rows before the first OOS window have no joined prediction count;
# represent that warmup state explicitly without filling any scores.
panel["prediction_window_count"] = panel["prediction_window_count"].fillna(0).astype(int)
else:
panel["linear_score_raw"] = np.nan
panel["ml_score_raw"] = np.nan
Expand Down
61 changes: 61 additions & 0 deletions tests/test_walkforward_validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,13 @@
aggregate_walkforward_predictions,
build_walkforward_windows,
resolve_walkforward_purge_days,
run_backtest_suite,
run_walkforward_scoring,
)
from src.evaluation import evaluate_live_pool_shadow, summarize_live_pool_shadow
from src.labels import build_labels
from src.models import ModelPredictionResult
from src.ranking import build_final_scores


class WalkforwardValidationTests(unittest.TestCase):
Expand Down Expand Up @@ -85,6 +87,65 @@ def fake_fit_predict_models(
self.assertEqual(int(window_summary.iloc[0]["purged_train_rows"]), 4)
self.assertEqual(int(scored["prediction_window_count"].max()), 1)

def test_walkforward_prefix_rows_are_warmup_before_backtest(self) -> None:
dates = pd.date_range("2024-01-01", periods=8, freq="D")
index = pd.MultiIndex.from_product([dates, ["AAA", "BBB"]], names=["date", "symbol"])
panel = pd.DataFrame(
{
"in_universe": True,
"blended_target": 1.0,
"feature_a": 1.0,
"rule_score": 0.5,
"regime": "late_momentum",
"open": 100.0,
},
index=index,
)
config = {
"walkforward": {
"train_window_days": 4,
"test_window_days": 2,
"step_days": 2,
"purge_days": 1,
"prediction_aggregation": "mean",
},
"labels": {"horizons": [1]},
"model": {"min_train_rows": 1},
"ensemble": {"default_weights": {"rule_score": 0.35, "linear_score": 0.20, "ml_score": 0.45}},
"regime_weights": {},
"ranking": {"selected_pool_size": 2},
"strategy": {
"rebalance_frequency": "daily",
"top_n": 2,
"weighting": "equal",
"signal_lag_days": 1,
"fee_bps": 0,
"slippage_bps": 0,
},
}

def fake_fit_predict_models(train_df, score_df, feature_columns, config):
predictions = pd.DataFrame(index=score_df.index)
predictions["linear_score_raw"] = 1.0
predictions["ml_score_raw"] = 1.0
return ModelPredictionResult(
predictions=predictions,
linear_backend="fake_linear",
ml_backend="fake_ml",
train_rows=len(train_df),
test_rows=len(score_df),
)

with patch("src.backtest.fit_predict_models", fake_fit_predict_models):
scored, _ = run_walkforward_scoring(panel, ["feature_a"], config)
scored = build_final_scores(scored, config)

prefix = (dates[:4], slice(None))
self.assertTrue(scored.loc[prefix, "final_score"].isna().all())
self.assertTrue(scored.loc[prefix, "prediction_window_count"].eq(0).all())
results = run_backtest_suite(scored, config)
self.assertIn("linear_score", results)

def test_purge_rejects_short_or_invalid_override_without_coercing_it(self) -> None:
for purge in (0, 1, -1, 2.5, True, False, "bad", "2.5", float("nan"), float("inf"), [], {}):
with self.subTest(purge=purge):
Expand Down