fix: skip invalid inverse-vol candidates - #183
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The scheduled lifecycle producer failed before publishing crypto inputs because inverse-vol selection could choose a top-score row with a non-finite vol20, producing NaN target weights and triggering the existing fail-closed backtest guard.
Fix
Filter non-finite vol20 candidates before top-N selection only for inverse-vol weighting. This preserves the strict finite long-only weight validation and lets a valid lower-ranked candidate be selected. Added a regression test covering the original failure.
Evidence
No workflow rerun, artifact publishing, deployment, or trading action was performed.