feat: transport Binance live intervals to monitor - #276
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Publish the approved Binance checkpoint cash flow interval from the existing Earn forward accounting path. The recorder keeps its existing PerformanceStore path and payload semantics; the cycle now also emits one optional redacted live-run JSON file for the monitor transport. The file uses the same recorder payload, preserves interval
Noneon failed or uncertain cycles, omits provider error text and order details, is atomically written with mode 0600, and is enabled only by the reviewed workflow path.The Runtime workflow stages that file only for ordinary enabled strategy runs, including failed cycles, as a private seven-day artifact named with the run ID and attempt. Validation, reconciliation, and disabled runs do not upload it.
Validation
python3 -m pytest -q tests/test_forward_earn_accounting.py tests/test_cycle_service.py tests/test_runtime_workflow_security.py— 142 passed, 7 subtests passedpython3 -m ruff check application/cycle_service.py tests/test_cycle_service.py tests/test_runtime_workflow_security.pygit diff --check2dc59d648af76382a08aaf6c84b19e9721fe8d6fNo broker cycle, order, or runtime workflow was triggered.