fix(binance): release stale owner under bounded preconditions - #275
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds an explicit, manually selected
release-stale-owneraccounting action for the disabledmain+reconcile_onlyRuntime workflow. It can delete only the existingMULTI_ASSET_STATE__ownerdocument after protected account identity, empty open-orders, safe order state, validACTIVE_LKGcontrol, and unchanged owner/ledger/control snapshots are confirmed.The Firestore operation is one
max_attempts=1transaction with owner-only deletion and mandatory readback. Missing owner is read-onlyalready_absent; any precondition change, transaction uncertainty, or readback uncertainty fails closed without retry. No ledger, control, risk, strategy, or execution fields are changed.Validation
PYTHONPATH=. uv run --frozen pytest -q— 901 passed, 91 subtests passeduv run --frozen ruff check scripts/migrate_daily_accounting_state.py tests/test_daily_accounting_migration.py tests/test_runtime_workflow_security.pygit diff --check