fix(binance): retain valid dividend surface diagnosis - #273
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve an independently complete BNB dividend surface diagnosis when the separate dribblet surface fails validation. The consumer now reuses the existing private in-memory dividend rows and
surface_diagnosticsto validate BNB asset, time window, unique identifiers, decimal amounts, and residual equality while keeping overall wallet completeness, dust, combined, and causal results unknown.The output also retains only integer
directionvalues plus missing and mixed flags. It does not infer net direction fromamountorenInfo, and it never exposes raw rows, amounts, IDs, timestamps, or metadata.Validation
PYTHONPATH=. uv run --no-sync pytest -q tests/test_earn_forward_diagnosis.py tests/test_balance_flow_diagnostics.py— 54 passedPYTHONPATH=. uv run --no-sync pytest -q— 867 passed, 91 subtests passeduv run --no-sync ruff check scripts/migrate_daily_accounting_state.py tests/test_earn_forward_diagnosis.pygit diff --checkNo production accounting, recovery, risk, owner, or execution behavior was changed. No runtime diagnosis was dispatched by this change.