fix(binance): bound daily state recovery diagnostics - #272
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
When a Binance cycle fails during the pure daily Earn preparation check, the runtime now releases only its own newly claimed owner when the order state is explicitly settled, no funding submission or pending funds occurred, and no post-load state write or side effect is present. Unknown orders and uncertain writes remain locked.
The read-only Earn diagnosis now performs a bounded
Spot1 → Earn1 → Spot2 → Earn2sample, records request ordering in memory, separates realtime reward growth from unexplained residuals, and keeps Firestore marker stability from masquerading as broker snapshot stability. BNB wallet diagnostics separately report row readability, visible rows, and window completeness; missing or invalid totals, full pages, duplicates, out-of-window rows, and non-BNB dividend rows remain unverified without discarding visible counts. Recovery documentation is synchronized.Validation
PYTHONPATH=. .venv/bin/pytest -q— 865 passed, 91 subtests passed.venv/bin/ruff checkon changed Python files — passedgit diff --check— passedNo remote account diagnostics, runtime enablement, order, subscription, redemption, or other funds operation was performed.