Add bounded BNB wallet evidence to Earn diagnosis - #271
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The bounded
earn-forward-diagnoserun can leave a positive BNB residual unexplained even when Spot/Flexible Earn, realtime counters, trades, and external flows are stable. The existing BNB wallet activity helper only returned counts, so one diagnostic run could not compare the already approvedassetDividendand Spotdribbletsurfaces.Change
diagnose_bnb_wallet_activitybackward compatible and optionally retain its two response row sets in memory for the new diagnostic consumer only.earn-forward-diagnose, call those two GETs only for a positive BNB residual when the other bounded checks are stable.targetAsset, and aggregate shape without exposing amounts or source IDs.Validation
.venv/bin/python -m pytest -q— 855 passed, 91 subtests passed..venv/bin/ruff check application/broker_reconciliation.py scripts/migrate_daily_accounting_state.py tests/test_balance_flow_diagnostics.py tests/test_earn_forward_diagnosis.py— passed.