Skip to content

Fix/review warnings - #11

Merged
luoxuanzao merged 2 commits into
mainfrom
fix/review-warnings
Aug 6, 2026
Merged

Fix/review warnings#11
luoxuanzao merged 2 commits into
mainfrom
fix/review-warnings

Conversation

@luoxuanzao

Copy link
Copy Markdown
Member

Summary

  • What changed?
  • Why is it needed?

Verification

  • npm run typecheck
  • npm run lint
  • npm run test
  • npm run build
  • npm run release:check
  • npm run audit:prod
  • Tested affected qodercli behavior against a real CLI when applicable

Safety

  • No credentials, private vault content, internal URLs, or personal paths are included
  • User-visible changes are documented in CHANGELOG.md

The explanatory prose between the title and the permission notice kept
licensee from matching the MIT template, so the marketplace review bot
reported the repository as having no recognized license. The Claudian
derivation note moves to NOTICE and the upstream copyright line is kept
verbatim in LICENSE.
- drop type assertions the compiler no longer needs, including the SDK
  effortLevel workaround that @qoder-ai/qoder-agent-sdk 1.0.16 made
  obsolete
- stop awaiting the void leaf.detach() in duplicate-leaf cleanup
- bind child.kill instead of extracting the unbound method in the
  Windows tree-aware kill shim
- mark intentionally fire-and-forget closePersistentQuery calls with
  void in resetSession and setSessionId
@luoxuanzao
luoxuanzao merged commit 9af0e96 into main Aug 6, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant