fix: custom MQTT advertised port - #73
Open
ndesgranges wants to merge 1 commit into
Open
Conversation
ndesgranges
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got issues during the onboarding and when setting up the android app using mitm.
Those issues where related to MQTT being advertised on a different port. I had errors about wrong cert, bad signatures etc.
These modifications where enough to fix it for me. I chose to add keys to the server to ease the patch, I just retrieve those and call it a day. Might not be the best solution according to your own coding rules and philosophy.
BTW, this was tested on "Roborock Qrevo S5V", with my own certificates (let's encrypt), it is working like a charm, thank you for the hard work !