Handle acme.sh renewal skip exit code - #72
Merged
Conversation
Lash-L
marked this pull request as ready for review
August 11, 2026 15:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RENEW_SKIPexit code (2) as a successful no-opRoot cause
CertificateManager._run_acme()treated every nonzero acme.sh exit code as fatal. acme.sh uses exit code2when renewal is intentionally skipped, so a valid existing certificate could cause server startup to fail.Impact
Server startup can continue and install/use the existing certificate when acme.sh reports that renewal is not due. Genuine ACME failures still raise
RuntimeError.Fixes #71
Validation
python -m pytest tests/test_certs.py -q— 6 passedpython -m pytest -q— 183 passed