Skip to content

fix(modal): use _weights instead of __weights in remove_item() - #3357

Open
vmphase wants to merge 2 commits into
masterfrom
fix/3356
Open

fix(modal): use _weights instead of __weights in remove_item()#3357
vmphase wants to merge 2 commits into
masterfrom
fix/3356

Conversation

@vmphase

@vmphase vmphase commented Aug 20, 2026

Copy link
Copy Markdown
Member

Summary

Fixes #3356

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.
  • I have read the Contributing Guidelines.
  • AI Usage has been disclosed.
    • If AI has been used, I understand fully what the code does

@vmphase
vmphase requested review from a team and DA-344 August 20, 2026 15:34
@vmphase
vmphase requested a review from NeloBlivion August 20, 2026 15:34
@github-project-automation github-project-automation Bot moved this to Todo in Pycord Aug 20, 2026
@vmphase
vmphase requested a review from JustaSqu1d August 20, 2026 15:34
@vmphase
vmphase requested a review from a team as a code owner August 20, 2026 15:34
@vmphase
vmphase requested review from Lulalaby and removed request for a team August 20, 2026 15:34
@pycord-app

pycord-app Bot commented Aug 20, 2026

Copy link
Copy Markdown

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3357/head:pr-3357
git checkout pr-3357

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3357/head

@Dorukyum Dorukyum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

Modal.remove_item() always raises AttributeError

2 participants