build: centralize backend dependencies on current Planner main - #693
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Keep the backend control plane, data plane, and shared types on the same Planner source when updating the integration. Backend main already pins the latest Planner main,
3be523fa0f06a905188e42cbe482d06aa843ba5d; this PR does not claim a version upgrade.What and how
Move the four Planner dependency definitions into workspace dependencies and inherit them at all eight use sites. Preserve the resolved source and Cargo.lock. Update the offline replay wrapper to read its pinned revision from the workspace manifest and remove obsolete per-crate migration comments.
Before this PR
Updating a Planner package required editing duplicate definitions across member manifests; for example,
planner-typeswas pinned separately in three crates.After this PR
Those three crates inherit one
planner-typesdefinition. All four Planner packages are maintained together in the root manifest. The offline report still records the same Planner revision. Query planning and serving behavior are unchanged.Verification
cargo +1.98.0 metadata --locked --no-deps: all eight declarations resolve to the same Planner source at current main.cargo +1.98.0 check --locked -p control_plane -p data_plane: passed (existing data-plane warnings).cargo +1.98.0 test --locked -p control_plane planner_selection: 10 passed.cargo +1.98.0 test --locked -p control_plane clickhouse::tests: 6 passed.This is dependency integration maintenance. It does not provide unified Prometheus/ClickHouse/VictoriaMetrics benchmarking or new runtime capabilities. Live database performance measurements are not applicable to this manifest-only integration change.