fix(promql): lower workloads with ingestion intervals - #417
Merged
zzylol merged 1 commit intoSep 18, 2026
Conversation
milindsrivastava1997
force-pushed
the
408-promql-instant-aggregates-lose-their-evaluation-horizon-and-lower-directly-over-scan
branch
from
September 14, 2026 14:22
c431b36 to
751a16d
Compare
Collaborator
Author
|
@zzylol Pls check the entire PR description. Code is in progress. |
milindsrivastava1997
marked this pull request as ready for review
September 14, 2026 23:05
Collaborator
Author
|
@zzylol code is done |
zzylol
previously approved these changes
Sep 18, 2026
zzylol
requested changes
Sep 18, 2026
zzylol
left a comment
Contributor
There was a problem hiding this comment.
I'm not sure why data ingestion interval is a requirement to lower for PromQL, it may be useful for dataworkload as input to planner in general.
Also, the data ingestion interval (sample scraping interval in prometheus), and the query window range are two concepts, not sure how they are related in this PR.
Collaborator
Author
|
@zzylol See issue 408. To convert PromQL instant selector queries to pre ASAP IR, we need a scrape interval. For range selector queries too, the scrape interval helps guide the possible sliding window choices we can use for precomputation. |
This was referenced Sep 18, 2026
Contributor
zzylol
force-pushed
the
408-promql-instant-aggregates-lose-their-evaluation-horizon-and-lower-directly-over-scan
branch
from
September 18, 2026 16:34
b56d0e2 to
37d1145
Compare
zzylol
changed the base branch from
main
to
refactor/data-workload-parallel
September 18, 2026 16:35
zzylol
changed the base branch from
refactor/data-workload-parallel
to
main
September 18, 2026 16:41
zzylol
force-pushed
the
408-promql-instant-aggregates-lose-their-evaluation-horizon-and-lower-directly-over-scan
branch
from
September 18, 2026 16:41
37d1145 to
1f1f099
Compare
zzylol
approved these changes
Sep 18, 2026
zzylol
deleted the
408-promql-instant-aggregates-lose-their-evaluation-horizon-and-lower-directly-over-scan
branch
September 18, 2026 18:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PromQL instant selectors need an explicit selection horizon that survives lowering and maintained-population compilation. This PR supplies it from source ingestion cadence.
Before this PR
Bare instant selectors lower directly to scans, losing their selection horizon; maintained current-series populations use a fixed expiry horizon.
After this PR
DataWorkload::data_ingestion_intervalsupplies a nonzero cadence. PromQL workload lowering accepts aPlanningWorkloadand explicit planning timestamp, rejects unavailable cadence evidence, and wraps instant selectors in the declared time range. Explicit range selectors keep their query range. Maintained populations preserve and validate the same expiry horizon through Post-ASAP IR handling and executable-DAG compilation.CLI tools, examples, and tests migrate to the workload lowering API. Freshness coverage includes future observations, expiry boundaries, expired evidence, and missing observation timestamps.
This PR targets
mainafter #442 merged. #442 introduced only the query/data workload split; this PR adds ingestion-interval lowering and IR handling.Validation
7fbfaf2(full workspace tests, formatting, and Clippy passed).