Skip to content

Unpin asap_sketchlib rev in workspace Cargo.toml #450

Description

@milindsrivastava1997

The workspace pins Sketchlib to a rev (Cargo.toml:17):

asap_sketchlib = { git = "https://github.com/ProjectASAP/asap_sketchlib", rev = "da3635a80f8f854d47b772d49d5a9e5fb6927d8e" }

Downstream repos (ASAPQuery-backend, ASAPCollector) depend on Sketchlib by its bare git URL. Cargo treats ?rev=… as a different source, so consumers end up with two copies of asap_sketchlib, which will cause type mismatches once Sketchlib types cross the Planner boundary.

Fix

  • Use asap_sketchlib = { git = "https://github.com/ProjectASAP/asap_sketchlib" } (bare URL, no rev/branch); Cargo.lock keeps builds reproducible.
  • Update Cargo.lock; fix any breakage against current Sketchlib main.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions