fix(precompute): scope compiled matchers to config - #604
Merged
Merged
Conversation
Contributor
Author
|
Follow-up review fix: malformed regex configs now fail closed. Invalid initial configs are not activated, and invalid updates leave the current active/staged config unchanged; tests cover both paths. |
zzylol
force-pushed
the
perf/594-generation-cache-pruning
branch
from
September 4, 2026 12:08
b435aa9 to
1acdee0
Compare
zzylol
force-pushed
the
fix/595-generation-scoped-regex
branch
from
September 4, 2026 12:08
f53f55c to
ffa64ab
Compare
zzylol
force-pushed
the
perf/594-generation-cache-pruning
branch
from
September 4, 2026 12:09
1acdee0 to
3fd59c4
Compare
zzylol
force-pushed
the
fix/595-generation-scoped-regex
branch
from
September 4, 2026 12:09
ffa64ab to
7c14a12
Compare
zzylol
changed the base branch from
perf/594-generation-cache-pruning
to
main
September 4, 2026 12:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #595.
Removes the unbounded process-global regex cache. Runtime configs now own their compiled regex objects, so retiring a plan generation releases its matcher memory. Compilation happens once during immutable config cloning; the observation hot path only calls
MatchString.Also exports
ValidateMatchersfor config/plan boundaries to reject malformed regexes before activation. Tests prove caller mutation cannot change installed matcher semantics and invalid patterns are rejected.Stacked on #603.