fix(ui): make the selected settings category legible - #78
Merged
Conversation
The selected category was filled with the accent and written in TEXT_PRIMARY. That pairing is below 4.5:1 on fifty-eight of the fifty-nine themes and reaches 1.01:1 on Ayu Dark, where the selected category was invisible against its own highlight. The open dropdown's highlighted row had the same pairing. Both now take their foreground from colony_ui::contrast_on, which picks the legible end for whatever accent the user has chosen. app_grid.rs already used it for exactly this, so the two settings sites were oversights rather than a choice. Found while porting the pattern into Digger, which would have inherited it. colony-ui goes to 0.1.4, which brings the six palettes whose bg_progress matched their bg_card and therefore drew an invisible progress track — all four Catppuccin variants among them. Colony draws its progress bars from the same token. The catalog grew to 26 families and 59 palettes on the way (Parchment, and upstream Kanagawa Dragon as its own variant beside the journal one that holds its const name). The doc-parity test caught every place the old counts were written down, which is what it is for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selected settings category is filled with the accent and written in
TEXT_PRIMARY. That pairing is below 4.5:1 on 58 of the 59 themes, and reaches 1.01:1 on Ayu Dark — the selected category was invisible against its own highlight. The highlighted row of an open dropdown had the same pairing.text_primaryonaccent_blueBoth sites now take their foreground from
colony_ui::contrast_on, which picks the legible end for whatever accent the user has chosen.app_grid.rsalready used it for exactly this, so these two were oversights rather than a deliberate choice.Found while porting the selection pattern into Digger, which would otherwise have inherited it.
colony-ui 0.1.4
Brings the six palettes whose
bg_progressmatched theirbg_cardand therefore drew a progress bar with no visible track — all four Catppuccin variants, Kanagawa journal and Parchment light. Colony draws its progress bars from the same token, so this fixes them here too. See Project-Colony-Resources#2.Documentation
The catalog grew to 26 families and 59 palettes — Parchment, and upstream Kanagawa Dragon as its own variant beside the journal one that holds its const name.
the_documented_theme_counts_match_the_codenamed all five documents that had the old numbers written down, which is what that test is for. The README's family table gains Parchment and Kanagawa's fourth variant.150 tests,
clippyclean.