Skip to content

Feature/increase subtitle offset #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndreOliveira23 wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −4
Open

Feature/increase subtitle offset #673

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e9ce40
feat(subtitles): Increasing max offset to 2 minutes
AndreOliveira23 Sep 8, 2026
e014ab7
feat(subtitles): Increasing max offset from 10 to 120 seconds
AndreOliveira23 Sep 8, 2026
ccd68ef
Merge remote-tracking branch 'origin/feature/increase-subtitle-offset…
AndreOliveira23 Sep 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions app/src/main/kotlin/com/arflix/tv/ui/screens/player/PlayerScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,8 @@ private const val PIP_ACTION_PLAY_PAUSE = "com.arflix.tv.pip.PLAY_PAUSE"
private const val PIP_ACTION_FORWARD = "com.arflix.tv.pip.FORWARD"
private const val QUICK_SEEK_DISMISS_DELAY_MS = 2_200L
private const val SEEK_PREVIEW_DEBOUNCE_MS = 60L
private const val MAX_SUBTITLE_OFFSET_MS = 120_000L
private const val SUBTITLE_OFFSET_STEP_MS = 100L

private fun isSafePlaybackHeader(name: String, value: String): Boolean {
return name.isNotBlank() &&
Expand Down Expand Up @@ -3186,15 +3188,15 @@ fun PlayerScreen(
}
Key.DirectionLeft -> {
when (subtitleSettingsRow) {
0 -> subtitleSyncOffsetMs = (subtitleSyncOffsetMs - 100L).coerceAtLeast(-10000L)
0 -> subtitleSyncOffsetMs = (subtitleSyncOffsetMs - SUBTITLE_OFFSET_STEP_MS).coerceAtLeast(-MAX_SUBTITLE_OFFSET_MS)
1 -> subtitleSizePct = (subtitleSizePct - 10).coerceAtLeast(50)
2 -> subtitleVerticalPct = (subtitleVerticalPct - 1).coerceAtLeast(0)
}
true
}
Key.DirectionRight -> {
when (subtitleSettingsRow) {
0 -> subtitleSyncOffsetMs = (subtitleSyncOffsetMs + 100L).coerceAtMost(10000L)
0 -> subtitleSyncOffsetMs = (subtitleSyncOffsetMs + SUBTITLE_OFFSET_STEP_MS).coerceAtMost(MAX_SUBTITLE_OFFSET_MS)
1 -> subtitleSizePct = (subtitleSizePct + 10).coerceAtMost(300)
2 -> subtitleVerticalPct = (subtitleVerticalPct + 1).coerceAtMost(50)
}
Expand Down Expand Up @@ -4415,8 +4417,8 @@ fun PlayerScreen(
sizePct = subtitleSizePct,
verticalPct = subtitleVerticalPct,
onRowSelect = { subtitleSettingsRow = it },
onOffsetDecrease = { subtitleSyncOffsetMs = (subtitleSyncOffsetMs - 100L).coerceAtLeast(-10000L) },
onOffsetIncrease = { subtitleSyncOffsetMs = (subtitleSyncOffsetMs + 100L).coerceAtMost(10000L) },
onOffsetDecrease = { subtitleSyncOffsetMs = (subtitleSyncOffsetMs - SUBTITLE_OFFSET_STEP_MS).coerceAtLeast(-MAX_SUBTITLE_OFFSET_MS) },
onOffsetIncrease = { subtitleSyncOffsetMs = (subtitleSyncOffsetMs + SUBTITLE_OFFSET_STEP_MS).coerceAtMost(MAX_SUBTITLE_OFFSET_MS) },
onSizeDecrease = { subtitleSizePct = (subtitleSizePct - 10).coerceAtLeast(50) },
onSizeIncrease = { subtitleSizePct = (subtitleSizePct + 10).coerceAtMost(300) },
onVerticalDecrease = { subtitleVerticalPct = (subtitleVerticalPct - 1).coerceAtLeast(0) },
Expand Down
Loading