I made an oopsie: detect spruce platform is ACTUALLY being used - #338
Open
Sundownersport wants to merge 1 commit into
Open
I made an oopsie: detect spruce platform is ACTUALLY being used#338Sundownersport wants to merge 1 commit into
Sundownersport wants to merge 1 commit into
Conversation
JanTrueno
approved these changes
Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlatformSpruce was added in #337 but never gets selected. harbour.py picks the
platform from hardware.py's device_info(), which has no spruce check, so devices
match trimui or miyoo instead. spruce runs on top of the stock firmware, so the
check has to come after those rather than before.
Also sets WANT_XBOX_FIX to true. spruce gives pugwash a positional pad on every
device, so it needs the same A/B correction the other platforms use.
Tested on a TrimUI Smart Pro S, an Anbernic RG28XX and a Powkiddy RGB30.
The diff is exactly what our launch-time patches do, so merging it lets us drop those later, and nothing breaks in the meantime if it sits unmerged. And the WANT_XBOX_FIX half reverses a value from our own previous PR.... my bad....