fix: resolve current account home directory

[Max-Sum]

NSHomeDirectoryForUser could return a container path instead of user directory.
Use getpwuid_r(getuid()) instead.

And also fix the hard-coded path in keymapping.

Just tried building with the latest source code, but NSHomeDirectoryForUser(userName) doesn’t seem to be working.

It returns /Users/$USER/Library/Containers/{App_Bundle_ID}/Data instead of /Users/$USER.

Originally posted by @viatearz in #221 (comment)

[TheMoonThatRises]

@viatearz can you provide some feedback? I can't tell if this is entirely necessary, i.e. why not just utilize NSHomeDirectoryForUser(userName) and strip back to the first two path components as slashes always represent directories/files.

[viatearz]

@viatearz can you provide some feedback? I can't tell if this is entirely necessary, i.e. why not just utilize NSHomeDirectoryForUser(userName) and strip back to the first two path components as slashes always represent directories/files.

@TheMoonThatRises I also prefer the simpler solution, as it will be easier to maintain.

But I would choose to strip the path at the first occurrence of /Library/Containers/, since the path prefix can vary when the home directory is located on an external disk.

[Max-Sum]

@viatearz can you provide some feedback? I can't tell if this is entirely necessary, i.e. why not just utilize NSHomeDirectoryForUser(userName) and strip back to the first two path components as slashes always represent directories/files.

@TheMoonThatRises I also prefer the simpler solution, as it will be easier to maintain.

But I would choose to strip the path at the first occurrence of /Library/Containers/, since the path prefix can vary when the home directory is located on an external disk.

Should we reply on the uncertain behavior of NSHomeDirectoryForUser which causes the issue in the first place?

[TheMoonThatRises]

From what I gather NSHomeDirectoryForUser returns the "home" path that iOS allows the application to see, which would be the sandbox path. I believe this was the original reason to utilizing the hard-coded home directory path previously, though undocumented. I believe @viatearz's plan for dynamically retrieving the proper home path to be a good solution, as it is easily maintainable.

[viatearz]

@TheMoonThatRises I think the getpwuid_r approach is also acceptable, although it is a bit complicated. Perhaps we should prioritize fixing the nightly version first.

[TheMoonThatRises]

Is it possible for the code to be simplified though? Theres a lot of memory operations for retrieving the home path

[TheMoonThatRises]

@ohaiibuzzle can I get your opinions on this?

[ohaiibuzzle]

@Max-Sum could you provide an instance of an app running into issues without this?

Please keep in mind that we do make use of the Apple App Sandbox, where $HOME is the Sandbox container is an intentional design.

If your app requires this, it's made wrong and broke Apple's rules.

https://developer.apple.com/documentation/foundation/nshomedirectory()?language=objc

[Max-Sum]

@Max-Sum could you provide an instance of an app running into issues without this?

Please keep in mind that we do make use of the Apple App Sandbox, where $HOME is the Sandbox container is an intentional design.

If your app requires this, it's made wrong and broke Apple's rules.

https://developer.apple.com/documentation/foundation/nshomedirectory()?language=objc

Previous implementation uses /Users, it already break out from the sandbox container. This patch does not introduce this behavior. All it does, together with #221, is just fixing crashes and unfunctional keymapping when the the home directory path is changed.

As far as the sandbox design, I have no opinion over this.