Skip to content

Fix the bug that setting WalkRate=0 on a TechnoType crashed the game (integer divide-by-zero) the moment an object of that type started moving - #2378

Merged
Coronia merged 1 commit into
Phobos-developers:developfrom
DeathFishAtEase:ZeroWalkRateFix
Aug 30, 2026
Merged

Conversation

@DeathFishAtEase

Copy link
Copy Markdown
Collaborator

What kind of change is this?

  • New feature, vanilla bugfix or enhancement of a released feature - changelog, docs and credits entries are needed.
  • Improvement to a new (unreleased) feature - docs and credits entries are needed; no changelog entry (Skip Changelog).
  • Bugfix to a new (unreleased) feature - credits entry is needed; no changelog or docs entries (Skip Changelog, Skip Docs).
  • Bugfix to an old (released) feature - changelog and credits entries are needed; no docs entry (Skip Docs).
  • Completely minor change (e.g. a typo fix) - no entries are needed (Skip Changelog, Skip Docs, Skip Credits).

Description

WalkRate was introduced in Tiberian Sun; unlike IdleRate, which was newly introduced in Red Alert 2, it does not have zero-value protection (see 0x4DA94A). This is now supplemented to align the semantics: when set to 0, playback will be disabled.

@DeathFishAtEase DeathFishAtEase self-assigned this Aug 30, 2026
@DeathFishAtEase DeathFishAtEase added ❓Vanilla bug Vanilla game bugs that are requested to be fixed Needs testing ⚙️T1 T1 maintainer review is sufficient labels Aug 30, 2026
@phoboscn-bot

Copy link
Copy Markdown

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户:
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息:

https://www.phoboscn.top/t/topic/751/1

@github-actions

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@DeathFishAtEase

DeathFishAtEase commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator Author

@DeathFishAtEase DeathFishAtEase added Tested Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions. and removed Needs testing labels Aug 30, 2026
@Coronia
Coronia merged commit 692c2da into Phobos-developers:develop Aug 30, 2026
31 checks passed
@DeathFishAtEase
DeathFishAtEase deleted the ZeroWalkRateFix branch August 30, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️T1 T1 maintainer review is sufficient Tested ❓Vanilla bug Vanilla game bugs that are requested to be fixed Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants