PMM-15379 Feature build - #4563
Draft
ademidoff wants to merge 1 commit into
Draft
Conversation
Collaborator
|
Server docker: perconalab/pmm-server-fb:PR-4563-e4eae77 |
Collaborator
|
API tests have succeded: https://pmm.cd.percona.com/job/pmm3-api-tests/7342/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PMM-15379
Component PRs
ci.yml
Single repo — only
percona/pmmis pinned; every other dependency stays at its default. Rebuilt components arepmm-managedandvmproxy.What QA needs to know
Two changes on the Grafana data source surface:
/graph/api/datasources/proxy/1/api/v1/...was filtered, so a user restricted by an access-control role could read unfiltered metrics through the UID form or through a data source whose numeric id was not 1./metrics,/flags,/debug/pprof/*,/api/v1/status/config,/api/v1/targets, the/api/v1/admin/*surface — returns403with a warn line in/srv/logs/vmproxy.lognaming the path.The main regression risk is dashboards
Change 2 restricts what can pass through the Metrics data source, so the thing worth testing hardest is that normal dashboard use is unaffected: panels render, template variables populate, Explore works, and QAN is unaffected. Any panel that breaks will leave a
Refusing request to a path outside the read-only allow-listline in/srv/logs/vmproxy.logwith the exact path — please attach that line if you hit one, it identifies a missing entry directly.Verified before submitting by driving 10 dashboards plus Explore in a browser against a patched 3.10.0 server: zero non-2xx responses, all template-variable lookups fine, and the deny log empty for the whole run. That was on a server with only PMM's own PostgreSQL monitored, so dashboards for MySQL, MongoDB, ProxySQL, HAProxy and the cloud integrations are exactly what this run did not cover.
Also worth checking
proxy/1./prometheus/*is unchanged and must still work — it does not cross vmproxy.